Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Thu, 27 Feb 2014 15:43:25 +0000 (UTC)
From: "Benedikt Ritter (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.12695402.1392549344340.118395.1393515805129@arcas>
In-Reply-To: <JIRA.12695402.1392549344340@arcas>
References: <JIRA.12695402.1392549344340@arcas>
Subject: [jira] [Commented] (SANDBOX-462) Refactoring of
 AccessibleObjectsRegistry
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/SANDBOX-462?page=3Dcom.atlassia=
n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D139=
14666#comment-13914666 ]=20

Benedikt Ritter commented on SANDBOX-462:
-----------------------------------------

Hello Andr=C3=A9

usually I've used mvn site and then looked at the check style report on the=
 generated site. Unfortunately the site build is currently broken. I have t=
o either release a new version of the sandbox parent pom find a different s=
olution for this problem.

To see what I've changed you can call

{code}
svn diff -r 1570311:1570312 src/main/java/org/apache/commons/beanutils2/Acc=
essibleObjectsRegistry.java
{code}

Was just about whitespaces, as you can see.

Regards,
Benedikt

> Refactoring of AccessibleObjectsRegistry
> ----------------------------------------
>
>                 Key: SANDBOX-462
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-462
>             Project: Commons Sandbox
>          Issue Type: Improvement
>          Components: BeanUtils2
>            Reporter: Andre Diermann
>            Priority: Minor
>         Attachments: Commons-BeanUtils2-462#1.patch
>
>
> Summary:
> The AccessibleObjectsRegistry class provides two get methods, while one i=
s a convenient method for the other.
> Both methods take one conditional parameter, boolean exact, and the actua=
l get method is very long, which makes it somehow complex to understand.
> Suggestion:
> What could be improved IMHO:
> - Instead of using conditional methods, like get(boolean doSomethingSpeci=
alIfTrue, ...), it is more convenient to provide dedicated methods like get=
Something() and getAnotherThing().
> - In this regard the difference between an exact or, let's call it, match=
ing descriptor should be expressed through inheritance rather than object a=
llocation (=3D expressing it by a field boolean exact).
> - The very long get method should be refined
> - Another very minor issue is the naming of the paramTypes field within t=
he inner AccessibleObjectDescriptor class, which I would suggest to rename =
to parameterTypes to fit the naming of the other occurrences.=20


--
This message was sent by Atlassian JIRA
(v6.1.5#6160)