Return-Path: X-Original-To: apmail-commons-issues-archive@minotaur.apache.org Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7923510A9F for ; Sat, 1 Feb 2014 12:52:13 +0000 (UTC) Received: (qmail 4158 invoked by uid 500); 1 Feb 2014 12:52:10 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 3806 invoked by uid 500); 1 Feb 2014 12:52:09 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 3798 invoked by uid 99); 1 Feb 2014 12:52:09 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 01 Feb 2014 12:52:09 +0000 Date: Sat, 1 Feb 2014 12:52:08 +0000 (UTC) From: "Benedikt Ritter (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (LANG-963) Clarify behavior of StringEscapeUtils.escapeXml be renaming it to StringEscapeUtils.escapeXmlEntities MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LANG-963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13888561#comment-13888561 ] Benedikt Ritter commented on LANG-963: -------------------------------------- I'm undecided whether we should change escapeHtml3 and escapeHtml4 to escapeHtml_3_Entities and escapeHtml_4_Entities... I don't like the underscores but I see no better way to decode the version into the method name. Further more this will be aligned to what we have for XML escaping after LANG-955 is resolved. > Clarify behavior of StringEscapeUtils.escapeXml be renaming it to StringEscapeUtils.escapeXmlEntities > ----------------------------------------------------------------------------------------------------- > > Key: LANG-963 > URL: https://issues.apache.org/jira/browse/LANG-963 > Project: Commons Lang > Issue Type: Improvement > Components: lang.* > Reporter: Benedikt Ritter > Assignee: Benedikt Ritter > Fix For: 3.3 > > > Although the documentation of {{StringEscaspeUtils.escapeXml(String)}} makes explicit that the method can only handle the basic XML entities, this should be clarified by renaming the method. The old method has be be deprecated and forwarded to the new method. -- This message was sent by Atlassian JIRA (v6.1.5#6160)