Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Mon, 3 Feb 2014 14:42:10 +0000 (UTC)
From: "Mark Thomas (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.12520023.1314220880403.27254.1391438530453@arcas>
In-Reply-To: <JIRA.12520023.1314220880403@arcas>
References: <JIRA.12520023.1314220880403@arcas>
Subject: [jira] [Resolved] (DBCP-364)
 BasicDataSourceFactory#createDataSource return signature should be
 BasicDataSourceFactory so that caller can invoke methods not declared in
 DataSource (e.g., close())
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/DBCP-364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Thomas resolved DBCP-364.
------------------------------

    Resolution: Fixed

Thanks for the report and sorry this has taken a while to fix.

This is an API change so it will be included in 2.0 onwards only.

> BasicDataSourceFactory#createDataSource return signature should be BasicDataSourceFactory so that caller can invoke methods not declared in DataSource (e.g., close())
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: DBCP-364
>                 URL: https://issues.apache.org/jira/browse/DBCP-364
>             Project: Commons Dbcp
>          Issue Type: Improvement
>            Reporter: ori
>            Priority: Trivial
>             Fix For: 2.0
>
>
> BasicDataSourceFactory#createDataSource currently returns a DataSource instance.
> It should a return type of BasicDataSourceFactory. Otherwise the caller has to cast it to invoke close (and other methods specific to the implementation).


--
This message was sent by Atlassian JIRA
(v6.1.5#6160)