commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Luc Maisonobe (JIRA)" <>
Subject [jira] [Commented] (MATH-1103) Convergence Checker Fixes
Date Thu, 27 Feb 2014 15:01:36 GMT


Luc Maisonobe commented on MATH-1103:

I don't think the call without the boolean parameter is as dangerous as the first one. In
the first case, the developer explicitly states he want to reuse the array, and it was an
error. In the second case, no assumption is made and the safe option (copying) is used.

Concerning the second patch, there is no added dependency, org.hamcrest is embedded into Junit.

So I think we could apply the patches, is this OK for you?

> Convergence Checker Fixes
> -------------------------
>                 Key: MATH-1103
>                 URL:
>             Project: Commons Math
>          Issue Type: Bug
>            Reporter: Evan Ward
>         Attachments: 0001-Fix-checker-seeing-not-old-point.patch, 0002-Fix-switched-iterations-and-evaluations.patch

This message was sent by Atlassian JIRA

View raw message