commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jason mathews (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (NET-525) Added missing set methods on NTP class and interface
Date Thu, 20 Feb 2014 15:47:19 GMT

    [ https://issues.apache.org/jira/browse/NET-525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13907055#comment-13907055
] 

jason mathews edited comment on NET-525 at 2/20/14 3:45 PM:
------------------------------------------------------------

Test is just checking the address is being set and non-null so that works.

I updated the patch with your suggested changed. Also, made minor change to NtpV3Impl.setDatagramPacket()
to copy datagram data + address rather than set the NtpV3Impl datagram to that packet.


was (Author: docjason):
Test is just checking the address is being set and non-null so that works.

> Added missing set methods on NTP class and interface
> ----------------------------------------------------
>
>                 Key: NET-525
>                 URL: https://issues.apache.org/jira/browse/NET-525
>             Project: Commons Net
>          Issue Type: Improvement
>    Affects Versions: 3.3
>            Reporter: jason mathews
>              Labels: ntp
>         Attachments: diff.patch.txt
>
>
> I was the original contributor of the NTP implementation and have recently cleaned the
source and submitting the relevant changes.
> Here is the summary of changes:
> src/main/java/org/apache/commons/net/ntp/TimeInfo.java
> -Added missing equals() and hashCode() methods
> -Added new method: getAddress() 
> src/main/java/org/apache/commons/net/ntp/NtpV3Packet.java
> -Added missing methods: setPrecision(), setRootDelay(), and setRootDispersion()
> src/main/java/org/apache/commons/net/ntp/NtpV3Impl.java
> -Added missing equals() and hashCode() methods
> -Added missing set methods: setRootDelay(), setRootDispersion(), 
> -Added validation check to setDatagramPacket()
> Added additional tests:
> -src/test/java/org/apache/commons/net/ntp/TestNtpPacket.java
> -src/test/java/org/apache/commons/net/ntp/TestTimeInfo.java
> See attached patch.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message