commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jason mathews (JIRA)" <j...@apache.org>
Subject [jira] [Created] (NET-525) Added missing set methods on NTP class and interface
Date Wed, 19 Feb 2014 20:37:19 GMT
jason mathews created NET-525:
---------------------------------

             Summary: Added missing set methods on NTP class and interface
                 Key: NET-525
                 URL: https://issues.apache.org/jira/browse/NET-525
             Project: Commons Net
          Issue Type: Improvement
    Affects Versions: 3.3
            Reporter: jason mathews


I was the original contributor of the NTP implementation and have recently cleaned the source
and submitting the relevant changes.

Here is the summary of changes:

src/main/java/org/apache/commons/net/ntp/TimeInfo.java
-Added missing equals() and hashCode() methods
-Added new method: getAddress() 

src/main/java/org/apache/commons/net/ntp/NtpV3Packet.java
-Added missing methods: setPrecision(), setRootDelay(), and setRootDispersion()

src/main/java/org/apache/commons/net/ntp/NtpV3Impl.java
-Added missing equals() and hashCode() methods
-Added missing set methods: setRootDelay(), setRootDispersion(), 
-Added validation check to setDatagramPacket()

Added additional tests:
-src/test/java/org/apache/commons/net/ntp/TestNtpPacket.java
-src/test/java/org/apache/commons/net/ntp/TestTimeInfo.java

See attached patch.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message