commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ivan Martinez-Ortiz (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CODEC-181) Make possible to provide padding byte to BaseNCodec in constructor
Date Mon, 24 Feb 2014 18:57:21 GMT

    [ https://issues.apache.org/jira/browse/CODEC-181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13910644#comment-13910644
] 

Ivan Martinez-Ortiz edited comment on CODEC-181 at 2/24/14 6:56 PM:
--------------------------------------------------------------------

  Hi Gary,

  I've created a new patch including a simple test in BaseNCodecTest (just verifies that the
pad byte passed through the constructor is actually stored).
  In addition I added the modified Base32 class that I had in my project and the modified
Base32TestCase.

  Regards,
    Ivan


was (Author: imartinez):
  Hi Gary,

  I've created a new patch including a simple test in BaseNCodecTest (just verifies that the
pad byte passed through the constructor is actually stored).
  In addition I added the Modified Base32 class that I had in my project and the modified
Base32TestCase.

  Regards,
    Ivan

> Make possible to provide padding byte to BaseNCodec in constructor
> ------------------------------------------------------------------
>
>                 Key: CODEC-181
>                 URL: https://issues.apache.org/jira/browse/CODEC-181
>             Project: Commons Codec
>          Issue Type: Improvement
>    Affects Versions: 1.9, 1.10
>            Reporter: Ivan Martinez-Ortiz
>            Priority: Minor
>         Attachments: BaseNCodec_new_constructor.patch, patch_with_test_case.diff
>
>
> Hi,
> I'm developing an application that generates QRCodes, so the user does not need to type
a HMAC value. QRCodes [1] supports different encoding formats, in particular the alpha numeric
format is almost compatible with the Base32 (the only problematic character is the '=' character).
> I created an almost exact copy of Base32 class in order to change the padding byte, however
the BaseNCodec#PAD byte is final and not settable in the class constructor.
> I already tested this approach and I can provide a patch to support this new feature.
> [1] http://en.wikipedia.org/wiki/QR_code



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message