commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stephen Compall (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (EXEC-81) Remove remaining rawtypes, unchecked conversions
Date Tue, 04 Feb 2014 05:30:09 GMT

    [ https://issues.apache.org/jira/browse/EXEC-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13890395#comment-13890395
] 

Stephen Compall edited comment on EXEC-81 at 2/4/14 5:29 AM:
-------------------------------------------------------------

Except for some changes in DefaultExecutorTest.java, this patch is entirely type-level.  There
is a purely type-level approach, but as this would change the API even more, I avoided it.
 If the intention is to support those things I changed to fit the types, though, then those
type-level API changes should be made anyway.  Please let me know what you think.

Side note: thanks very much to Sebastian Bazley for implementing all the nice rawtypes removal
elsewhere last month.  For me, this was quite serendipitous.


was (Author: s11001001):
Except for some changes in DefaultExecutorTest.java, this patch is entirely type-level.  There
is a purely type-level approach, but as this would change the API, I avoided it.  If the intention
is to support those things I changed to fit the types, though, then those type-level API changes
should be made anyway.  Please let me know what you think.

Side note: thanks very much to Sebastian Bazley for implementing all the nice rawtypes removal
elsewhere last month.  For me, this was quite serendipitous.

> Remove remaining rawtypes, unchecked conversions
> ------------------------------------------------
>
>                 Key: EXEC-81
>                 URL: https://issues.apache.org/jira/browse/EXEC-81
>             Project: Commons Exec
>          Issue Type: Improvement
>         Environment: Java 1.7.0_45
>            Reporter: Stephen Compall
>            Priority: Minor
>         Attachments: rawtypes-unchecked-clean.diff
>
>
> This patch -p1 against r1557571 eliminates the remaining raw type in the API, and makes
src and test entirely -Xlint:rawtypes -Xlint:unchecked clean.  (In fact it should be clean
over all of -Xlint except for one [cast] and one [deprecation] warning.)



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message