Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Sat, 11 Jan 2014 13:07:57 +0000 (UTC)
From: "Benedikt Ritter (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.12667797.1378817248329.82086.1389445677143@arcas>
In-Reply-To: <JIRA.12667797.1378817248329@arcas>
References: <JIRA.12667797.1378817248329@arcas>
Subject: [jira] [Commented] (LANG-915) Wrong locale handling in
 LocaleUtils.toLocale()
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/LANG-915?page=3Dcom.atlassian.j=
ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D138687=
64#comment-13868764 ]=20

Benedikt Ritter commented on LANG-915:
--------------------------------------

Hello Sergio,

I've reviewed your patch. You're using tabs to intend your code. At commons=
 we uses spaces instead, since the representation of the tab character vari=
es between different editors. I've corrected this.

The new method {{StringUtils.occurences(String, String)}} seems to duplicat=
e {{StringUtils.countMatches(CharSequence, CharSequence)}}. I've removed it=
. Your new method caused {{StringUtilsTest.testStringUtilsCharSequenceContr=
act()}} to fail. It's always good to run {{mvn clean test}} before creating=
 a patch, to be sure everything still works.

All tests pass now. I've committed your patch in rev. 1557378.

Thanks for contributing!

> Wrong locale handling in LocaleUtils.toLocale()
> -----------------------------------------------
>
>                 Key: LANG-915
>                 URL: https://issues.apache.org/jira/browse/LANG-915
>             Project: Commons Lang
>          Issue Type: Bug
>    Affects Versions: 3.1
>            Reporter: Sergio Fern=C3=A1ndez
>            Priority: Minor
>             Fix For: 3.3
>
>         Attachments: LANG-915-test.patch, LANG-915.patch
>
>
> The static method LocaleUtils.toLocale() fails, at least, to parse 3-char=
 locale strings, which are completelly valid BCP47 locales.


--
This message was sent by Atlassian JIRA
(v6.1.5#6160)