commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefan Bodewig (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (COMPRESS-253) BZip2CompressorInputStream reads less bytes from truncated file than CPython's bz2 implementation
Date Tue, 07 Jan 2014 11:04:50 GMT

     [ https://issues.apache.org/jira/browse/COMPRESS-253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Stefan Bodewig updated COMPRESS-253:
------------------------------------

    Attachment: compress-253.patch

The reason for this is that BZIp2CompressorInputStream always calculates the next byte when
reading one.

The attached patch (against current trunk) changes this and removes a piece of state at the
same time.  All existing tests inside Common Compress pass with the change but we are pretty
close to release 1.7 and I don't feel well adding the change now without more extensive testing.

> BZip2CompressorInputStream reads less bytes from truncated file than CPython's bz2 implementation
> -------------------------------------------------------------------------------------------------
>
>                 Key: COMPRESS-253
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-253
>             Project: Commons Compress
>          Issue Type: Bug
>          Components: Compressors
>    Affects Versions: 1.4.1, 1.6, 1.7
>            Reporter: Indra Talip
>            Priority: Minor
>         Attachments: PythonTruncatedBzip2Test.java, compress-253.patch
>
>
> Jython includes support for decompressing bz2 files using commons compress and shares
regression tests with CPython. The CPython test [test_read_truncated|https://bitbucket.org/jython/jython/src/b2890af7a5e817e30f6ca2325f6dcdb14a59f32b/lib-python/2.7/test/test_bz2.py?at=default#cl-331]
in test_bz2.py passes under CPython but fails under Jython.
> The BZip2CompressorInputStream is able to read 769 bytes from the truncated data rather
than the 770 bytes that the CPython bz2 implementation can read.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message