Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Thu, 5 Dec 2013 18:14:35 +0000 (UTC)
From: "Woonsan Ko (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.12682899.1386248520004.79346.1386267275867@arcas>
In-Reply-To: <JIRA.12682899.1386248520004@arcas>
References: <JIRA.12682899.1386248520004@arcas>
Subject: [jira] [Comment Edited] (SCXML-183) Expose JexlEngine strict/silent
 mode settings  through the JexlEvaluator for easier customization
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/SCXML-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13840335#comment-13840335 ] 

Woonsan Ko edited comment on SCXML-183 at 12/5/13 6:12 PM:
-----------------------------------------------------------

Thanks for the nice improvement!
I have a question on the change: if it is deserialized, then jexlEngine is null and it will recreated later as requested. In this case, the strict/silent options settings seem to be lost. So maybe wouldn't it be better to have the options setting code in #createJexlEngine() as well?


was (Author: woon_san):
Thanks for the nice improvement!
I have a question on the change: if it is deserialized, then jexlEngine is null and it will recreated later as requested. In this case, the strict/silent options settings seem to be lost. So maybe wouldn't it be better to move the options setting code into #createJexlEngine() instead of the current setters?

> Expose JexlEngine strict/silent mode settings  through the JexlEvaluator for easier customization
> -------------------------------------------------------------------------------------------------
>
>                 Key: SCXML-183
>                 URL: https://issues.apache.org/jira/browse/SCXML-183
>             Project: Commons SCXML
>          Issue Type: Improvement
>    Affects Versions: 2.0
>            Reporter: Ate Douma
>            Assignee: Ate Douma
>             Fix For: 2.0
>
>
> Currently the JexlEvaluator creates the JexlEngine with mostly default settings.
> The JexlEvaluator class can be extended to override the createEngine method and thus allows custom configurations, but this is less convenient.
> Especially the JexlEngine strict/silent mode settings are important with regard to its internal behavior.
> By exposing these settings through the JexlEvaluator it no longer is needed to extend to control these settings.


--
This message was sent by Atlassian JIRA
(v6.1#6144)