Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Tue, 3 Dec 2013 09:48:35 +0000 (UTC)
From: "Ate Douma (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.12682242.1386023196587.60591.1386064115454@arcas>
In-Reply-To: <JIRA.12682242.1386023196587@arcas>
References: <JIRA.12682242.1386023196587@arcas>
Subject: [jira] [Commented] (SCXML-179) Leave more context (location)
 information when failing to execute JEXL scripts
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/SCXML-179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13837505#comment-13837505 ] 

Ate Douma commented on SCXML-179:
---------------------------------

Hi Woonsan, nice improvement.

However I'm still puzzled by the Jexl error location (161![14,22]) which seems weird, as those line numbers(161 AND 14?) don't add up or match with the source.
This is probably more of an Jexl issue I guess, but it would be nice if somehow this could be improved as well, ideally of course with exact line/column info within the SCXML source document.
I'm not saying this should be fixed or further improved right now, but maybe something to look into at a later time?

> Leave more context (location) information when failing to execute JEXL scripts
> ------------------------------------------------------------------------------
>
>                 Key: SCXML-179
>                 URL: https://issues.apache.org/jira/browse/SCXML-179
>             Project: Commons SCXML
>          Issue Type: Improvement
>            Reporter: Woonsan Ko
>            Assignee: Woonsan Ko
>            Priority: Minor
>             Fix For: 2.0
>
>
> Currently, it doesn't give enough context (location) information in warning logs when there are script errors (e.g, undefined object usages) like the following:
> EXPRESSION_ERROR (evalScript('
>         unknownObject.invoke();
>       '):org.apache.commons.scxml2.env.jexl.JexlEvaluator.evalScript@161![14,22]: 'unknownObject.invoke();' attempting to call method on null):
> The line number above (161) is from JexlEvaluator, not from SCXML source.
> It would be better if it gave more information somehow about the SCXML location and element location, for instance.


--
This message was sent by Atlassian JIRA
(v6.1#6144)