Return-Path: X-Original-To: apmail-commons-issues-archive@minotaur.apache.org Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8697F10F82 for ; Tue, 17 Dec 2013 22:54:08 +0000 (UTC) Received: (qmail 59607 invoked by uid 500); 17 Dec 2013 22:54:08 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 59527 invoked by uid 500); 17 Dec 2013 22:54:08 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 59518 invoked by uid 99); 17 Dec 2013 22:54:08 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Dec 2013 22:54:08 +0000 Date: Tue, 17 Dec 2013 22:54:07 +0000 (UTC) From: "Emmanuel Bourg (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CSV-102) Commons CSV does not properly handle record separators MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CSV-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13851046#comment-13851046 ] Emmanuel Bourg commented on CSV-102: ------------------------------------ Ok understood. I'm under the impression it would add a fair amount of complexity for a case that might never be used. commons-csv doesn't aim at parsing any structured text format that vaguely look like a CSV file. Having records separated by a line break looks like a minimal expectation to me. If it's really necessary to parse a file with a record separator other than a line break I would suggest preprocessing the file to transform the separators into line breaks before feeding it to commons-csv. But that task would be out of the scope of commons-csv. > Commons CSV does not properly handle record separators > ------------------------------------------------------ > > Key: CSV-102 > URL: https://issues.apache.org/jira/browse/CSV-102 > Project: Commons CSV > Issue Type: Bug > Affects Versions: 1.x > Environment: ALL > Reporter: Oliver Oyston > Priority: Minor > Attachments: Changes.patch, nonstandard.patch > > > Any specified record separator appear to be ignored and the code just assumes that standard line endings are the record delimiters. > I have a patch to partly address the problems that 'falls back' to the current behavior. The patch only allow a maximum of a one character record separator. > The approach needs verifying and also needs improving to be more generic. -- This message was sent by Atlassian JIRA (v6.1.4#6159)