Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Fri, 6 Dec 2013 19:55:36 +0000 (UTC)
From: "Sebb (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.12658831.1374268995106.87661.1386359736670@arcas>
In-Reply-To: <JIRA.12658831.1374268995106@arcas>
References: <JIRA.12658831.1374268995106@arcas>
Subject: [jira] [Updated] (NET-513) [patch
 attached]SubnetUtils.SubnetInfo.getAllAddresses() Doesn't return all
 addresses
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/NET-513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sebb updated NET-513:
---------------------

    Labels:   (was: easyfix patch)

> [patch attached]SubnetUtils.SubnetInfo.getAllAddresses() Doesn't return all addresses
> -------------------------------------------------------------------------------------
>
>                 Key: NET-513
>                 URL: https://issues.apache.org/jira/browse/NET-513
>             Project: Commons Net
>          Issue Type: Bug
>    Affects Versions: 3.3
>            Reporter: akash kushwaha
>
> SubnetInfo.getAllAddresses() Doesn't return all addresses, but return all but 2 addresses.
> Fixing code at following lines worked for me.
> 	        private int low()           { return network() ; }
> 	        private int high()          { return broadcast() ; }
> public int getAddressCount()                { return (broadcast() - low() + 1); }
> 	            //j < addresses.length added as for loop will run infinitely when high is Integer.MAX_VALUE test case: 127.0.0.0/8
> 	            for (int add = low(), j=0; add <= high() && j < addresses.length; ++add, ++j) {


--
This message was sent by Atlassian JIRA
(v6.1#6144)