Return-Path: X-Original-To: apmail-commons-issues-archive@minotaur.apache.org Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6B83910973 for ; Mon, 9 Dec 2013 20:48:08 +0000 (UTC) Received: (qmail 7807 invoked by uid 500); 9 Dec 2013 20:48:08 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 7615 invoked by uid 500); 9 Dec 2013 20:48:07 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 7429 invoked by uid 99); 9 Dec 2013 20:48:07 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Dec 2013 20:48:07 +0000 Date: Mon, 9 Dec 2013 20:48:07 +0000 (UTC) From: "Mark Thomas (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (DBCP-319) Make private fields final where possible MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DBCP-319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved DBCP-319. ------------------------------ Resolution: Fixed I agree with Phil. It is reasonable to set the wrapped connection to null in these circumstances. > Make private fields final where possible > ---------------------------------------- > > Key: DBCP-319 > URL: https://issues.apache.org/jira/browse/DBCP-319 > Project: Commons Dbcp > Issue Type: Improvement > Reporter: Sebb > Fix For: 2.0 > > Attachments: DBCP-319-private-final.patch > > > Several private fields could be made final: > AbandonedTrace.config > AbandonedTrace.AbandonedObjectException._createdTime > cpdsadapter.PooledConnectionImpl: > * connection > * delegatingConnection > * eventListeners > * statementEventListeners > * pstmtPool is protected, but could probably be made final if it were not for the API change that would imply > cpdsadapter.PooledConnectionImpl.PStmtKey (nested class, variables are protected, but might as well be private) > * all of its fields could be made final > datasources.[Keyed]CPDSConnectionFactory.validatingMap > datasources.[Keyed]CPDSConnectionFactory.pcMap > managed.PoolableManagedConnection.transactionRegistry > managed.PoolableManagedConnectionFactory.transactionRegistry > managed.TransactionRegistry.transactionManager|caches|xaResources > .AbandonedObjectPool.config|trace -- This message was sent by Atlassian JIRA (v6.1.4#6159)