commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LANG-935) Possible performance improvement on string escape functions
Date Fri, 13 Dec 2013 11:04:07 GMT

    [ https://issues.apache.org/jira/browse/LANG-935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13847407#comment-13847407
] 

Sebb commented on LANG-935:
---------------------------

Thanks, but as provided, we cannot use the source, because at least one header states that
the code is licensed under LGPL 2.1.
I did not read any further when I saw that.

If it is all your own work, this can easily be resolved by providing new versions with the
appropriate AL header (see any existing files for examples). Note that we don't include Copyright
statements or @author tags (usually - there may be some legacy instances).

In the case of updates to existing classes, please provide these as unified diffs, and please
stick to the existing package naming.
Brand new classes can be provided as source rather than diffs.

> Possible performance improvement on string escape functions
> -----------------------------------------------------------
>
>                 Key: LANG-935
>                 URL: https://issues.apache.org/jira/browse/LANG-935
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.text.translate.*
>    Affects Versions: 3.1
>            Reporter: Peter Wall
>            Priority: Minor
>              Labels: performance
>             Fix For: Patch Needed
>
>         Attachments: tempproject1.zip
>
>
> The escape functions for HTML etc. use the same code and the same initialisation tables
for the escape and unescape functions, and while this is an elegant approach it leads to a
number of deficiencies:
> 1. The code is very much less efficient than it could be
> 2. A new output string is created even when no conversion is required
> 3. No mapping is provided for characters that do not have a specific representation (for
example HTML 0x101 should become &amp;#257; )
> The proposal is to use a new mapping technique to address these issues



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Mime
View raw message