commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Woonsan Ko (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SCXML-177) Correct error/warning messages in SCXML reading to be up-to-date
Date Tue, 03 Dec 2013 17:10:35 GMT

    [ https://issues.apache.org/jira/browse/SCXML-177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13837906#comment-13837906
] 

Woonsan Ko commented on SCXML-177:
----------------------------------

Thanks for the suggestions!

I've looked up how JEXL is doing with that kind of options as an example. It has strict/lenient
option to determine whether or not it is an error, and silent option to determine whether
or not it should leave warning logs. [1]
So, I think we can add the following in SCXMLReader:
+ boolean isStrict();
+ void setStrict(boolean strict);
+ boolean isLenient();
+ void setLenient(boolean lenient); // { this.strict = !lenient; }
+ boolean isSilent();
+ void setSilent(boolean silent);

The default options can be ( !strict && !silent ), which gives warning logs by default.

[1] http://commons.apache.org/proper/commons-jexl/apidocs/org/apache/commons/jexl2/JexlEngine.html
     (The javadoc was not precise about 'silent' option. It only determine whether or not
the exception should be logged as WARN level. It doesn't force to throw an exception.)

> Correct error/warning messages in SCXML reading to be up-to-date
> ----------------------------------------------------------------
>
>                 Key: SCXML-177
>                 URL: https://issues.apache.org/jira/browse/SCXML-177
>             Project: Commons SCXML
>          Issue Type: Bug
>            Reporter: Woonsan Ko
>            Assignee: Woonsan Ko
>            Priority: Trivial
>             Fix For: 2.0
>
>
> Some error/warning logs are outdated against the newest spec.
> For example,
> org.apache.commons.scxml2.model.ModelException: No SCXML child state with ID "null" found;
illegal initialstate for SCXML document
> 	at org.apache.commons.scxml2.io.ModelUpdater.logAndThrowModelError(ModelUpdater.java:297)
> It should inform of 'initial', not 'initialstate' and check if it is not set.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message