Return-Path: X-Original-To: apmail-commons-issues-archive@minotaur.apache.org Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EF53FC3E6 for ; Sun, 3 Nov 2013 20:24:17 +0000 (UTC) Received: (qmail 87349 invoked by uid 500); 3 Nov 2013 20:24:17 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 87268 invoked by uid 500); 3 Nov 2013 20:24:17 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 87260 invoked by uid 99); 3 Nov 2013 20:24:17 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 03 Nov 2013 20:24:17 +0000 Date: Sun, 3 Nov 2013 20:24:17 +0000 (UTC) From: "Thomas Neidhart (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (MATH-1057) BOBYQAOptimizerTest has two failing tests MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MATH-1057?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D13812= 474#comment-13812474 ]=20 Thomas Neidhart commented on MATH-1057: --------------------------------------- For the testDiffPow testcase, I further debugged with the two different jdk= s, and after iteration 2219 the objective function output changes. The difference/error then accumulates and results that the algorithm conver= ges much slower. I could track down the problem to the Math implementation,= most likely the sqrt or exp. Changing all the Math calls to our own FastMa= th solves the problem and the test executes correctly for all jdks. I wonder why we use Math in the first place, as normally we eat our own dog= -food and use FastMath. btw. the problem also is existent in the 3.2 release so not at all related = to your previous patch. > BOBYQAOptimizerTest has two failing tests > ----------------------------------------- > > Key: MATH-1057 > URL: https://issues.apache.org/jira/browse/MATH-1057 > Project: Commons Math > Issue Type: Bug > Affects Versions: 3.2 > Environment: Mac OS X 10.9 and also Linux 3.4 kernel; Java 7; Mav= en 3.1.1 > Reporter: Sean Owen > Priority: Minor > > I see two test failures, in both the copies of BOBYQAOptimizerTest: > {code} > Failed tests:=20 > BOBYQAOptimizerTest.testAckley:209->doTest:282->doTest:338 expected:<0.= 0> but was:<1.047765607609108E-8> > BOBYQAOptimizerTest.testAckley:208->doTest:281->doTest:336 expected:<0.= 0> but was:<1.047765607609108E-8> > Tests in error:=20 > BOBYQAOptimizerTest.testDiffPow:187->doTest:282->doTest:322 =C2=BB TooM= anyEvaluations > BOBYQAOptimizerTest.testDiffPow:186->doTest:281->doTest:326 =C2=BB TooM= anyEvaluations > {code} > (This predated the patches I've worked on so I don't think it's me!) > I tried on Mac OS X and Linux and see the same, so don't think it is an e= nvironment issue. I'll see if a little digging can uncover the issue from a= recent commit. -- This message was sent by Atlassian JIRA (v6.1#6144)