Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Fri, 25 Oct 2013 23:54:31 +0000 (UTC)
From: "Sebb (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.12675893.1382736699386.5606.1382745271701@arcas>
In-Reply-To: <JIRA.12675893.1382736699386@arcas>
References: <JIRA.12675893.1382736699386@arcas>
Subject: [jira] [Comment Edited] (IO-404) [IO] Don't buffer
 ByteArrayInputStream
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/IO-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13805799#comment-13805799 ] 

Sebb edited comment on IO-404 at 10/25/13 11:54 PM:
----------------------------------------------------

I agree that BIS does not offer any new methods compared with IS.
However, it does provide some protected variables which are not in BAIS.

-Also, changing the return type would break binary compatibility, and would probably affect source compatibility (would still true even if there were no protected variables involved).-

Note: similar considerations apply to ByteArrayOutputStream.


was (Author: sebb@apache.org):
I agree that BIS does not offer any new methods compared with IS.
However, it does provide some protected variables which are not in BAIS.

Also, changing the return type would break binary compatibility, and would probably affect source compatibility (would still true even if there were no protected variables involved).

Note: similar considerations apply to ByteArrayOutputStream.

> [IO] Don't buffer ByteArrayInputStream
> --------------------------------------
>
>                 Key: IO-404
>                 URL: https://issues.apache.org/jira/browse/IO-404
>             Project: Commons IO
>          Issue Type: Improvement
>          Components: Utilities
>    Affects Versions: 2.5
>            Reporter: BELUGA BEHR
>            Priority: Minor
>
> The new method:
> public static BufferedInputStream buffer(final InputStream inputStream)
> Is there some way to detect when the InputStream is a ByteArrayInputStream and to just return itself... or requiring a light wrapper?  Perhaps the method signature should be changed to just return an InputStream instead of a specifying BufferedInputStream.  What benefit does that give you anyway?


--
This message was sent by Atlassian JIRA
(v6.1#6144)