commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henri Yandell (JIRA)" <j...@apache.org>
Subject [jira] [Created] (LANG-929) OctalUnescaper code is complex, leading to bugs
Date Sat, 26 Oct 2013 02:20:31 GMT
Henri Yandell created LANG-929:
----------------------------------

             Summary: OctalUnescaper code is complex, leading to bugs
                 Key: LANG-929
                 URL: https://issues.apache.org/jira/browse/LANG-929
             Project: Commons Lang
          Issue Type: Improvement
          Components: lang.text.translate.*
            Reporter: Henri Yandell
            Assignee: Henri Yandell
             Fix For: Patch Needed


My gut is that the code in OctalUnescaper is unnecessarily complex. It feels simpler to look
at the legitimate values for an Octal more explicitly. 

Thinking the current code through, it fails if you pass it \279. That should be octal \27
followed by a 9, but instead it will try to parse it as an Octal and throw a NumberFormatException.




--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message