commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (IO-404) [IO] Don't buffer ByteArrayInputStream
Date Fri, 25 Oct 2013 23:54:31 GMT

    [ https://issues.apache.org/jira/browse/IO-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13805799#comment-13805799
] 

Sebb edited comment on IO-404 at 10/25/13 11:54 PM:
----------------------------------------------------

I agree that BIS does not offer any new methods compared with IS.
However, it does provide some protected variables which are not in BAIS.

-Also, changing the return type would break binary compatibility, and would probably affect
source compatibility (would still true even if there were no protected variables involved).-

Note: similar considerations apply to ByteArrayOutputStream.


was (Author: sebb@apache.org):
I agree that BIS does not offer any new methods compared with IS.
However, it does provide some protected variables which are not in BAIS.

Also, changing the return type would break binary compatibility, and would probably affect
source compatibility (would still true even if there were no protected variables involved).

Note: similar considerations apply to ByteArrayOutputStream.

> [IO] Don't buffer ByteArrayInputStream
> --------------------------------------
>
>                 Key: IO-404
>                 URL: https://issues.apache.org/jira/browse/IO-404
>             Project: Commons IO
>          Issue Type: Improvement
>          Components: Utilities
>    Affects Versions: 2.5
>            Reporter: BELUGA BEHR
>            Priority: Minor
>
> The new method:
> public static BufferedInputStream buffer(final InputStream inputStream)
> Is there some way to detect when the InputStream is a ByteArrayInputStream and to just
return itself... or requiring a light wrapper?  Perhaps the method signature should be changed
to just return an InputStream instead of a specifying BufferedInputStream.  What benefit does
that give you anyway?



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message