commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gilles (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (MATH-1047) No check for overflow in "ArithmeticUtils.pow"
Date Wed, 30 Oct 2013 22:09:26 GMT

    [ https://issues.apache.org/jira/browse/MATH-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13809685#comment-13809685
] 

Gilles edited comment on MATH-1047 at 10/30/13 10:08 PM:
---------------------------------------------------------

Method "pow(long,int)" modified in revision 1537324 (using "mulAndCheck(long,long)").
If a more efficient version is needed (possibly without safety check), it will need to be
reimplemented with another name, and documentation that clearly indicates the purpose and
caveat.



was (Author: erans):
Method "pow(long,long)" modified in revision 1537324 (using "mulAndCheck(long,long)").
If a more efficient version is needed (possibly without safety check), it will need to be
reimplemented with another name, and documentation that clearly indicates the purpose and
caveat.


> No check for overflow in "ArithmeticUtils.pow"
> ----------------------------------------------
>
>                 Key: MATH-1047
>                 URL: https://issues.apache.org/jira/browse/MATH-1047
>             Project: Commons Math
>          Issue Type: Improvement
>    Affects Versions: 3.2
>            Reporter: Gilles
>              Labels: safety
>             Fix For: 3.3
>
>         Attachments: MATH-1047.patch
>
>
> The "pow" methods in "o.a.c.m.util.ArithmeticUtils" do not check for overflow.
> They will happily return nonsensical results.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message