commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henri Yandell (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LANG-922) Add isOneTrue(booleans...) to BooleanUtils to preserve old behavior of BooleanUtils.xor(booleans...)
Date Mon, 21 Oct 2013 20:37:49 GMT

    [ https://issues.apache.org/jira/browse/LANG-922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13801049#comment-13801049
] 

Henri Yandell commented on LANG-922:
------------------------------------

Agreed. LANG-921 fixing the bug is goodness :)

I don't see a need to maintain the old functionality. I'm in favour of dropping the 3.2 fix
version on this one.

We could add:

ArrayUtils.frequency;int
ArrayUtils.isFrequencyAtLeast;boolean
ArrayUtils.isFrequenctAtMost;boolean

I'm not convinced the latter methods are worth having, but I like the former method.

> Add isOneTrue(booleans...) to BooleanUtils to preserve old behavior of BooleanUtils.xor(booleans...)
> ----------------------------------------------------------------------------------------------------
>
>                 Key: LANG-922
>                 URL: https://issues.apache.org/jira/browse/LANG-922
>             Project: Commons Lang
>          Issue Type: Bug
>          Components: lang.*
>            Reporter: Benedikt Ritter
>            Assignee: Benedikt Ritter
>             Fix For: 3.2, Discussion
>
>
> The old implementation (prior to r1532476) of BooleanUtils.xor(boolean...) checked if
the provided array contained exactly one boolean with value true. This was changed because
it is not the correct behavior for an XOR operation. To preserve the behavior we should add
BooleanUtils.isOneTrue(boolean...) and BooleanUtils.isOneTrue(Boolean...) (and possibly the
equivalents for isOneFalse).



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message