commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gilles (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MATH-1041) Add Pair factory method, toString(), Comparator
Date Wed, 16 Oct 2013 08:45:42 GMT

    [ https://issues.apache.org/jira/browse/MATH-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13796567#comment-13796567
] 

Gilles commented on MATH-1041:
------------------------------

I've already committed some changes, one at a time. Sorry if I've been to fast. :)
Could you please update your working copy, and provide further changes in separate patches?
E.g. it would be nice to have one patch for the comparator code and unit tests.


> Add Pair factory method, toString(), Comparator 
> ------------------------------------------------
>
>                 Key: MATH-1041
>                 URL: https://issues.apache.org/jira/browse/MATH-1041
>             Project: Commons Math
>          Issue Type: Improvement
>    Affects Versions: 3.2
>            Reporter: Sean Owen
>            Priority: Minor
>              Labels: comparator, pair
>         Attachments: MATH-1041.patch
>
>
> I use Commons Math heavily, and have adopted its Pair class for the cases where I need,
well, a pair of things.
> The attached patch adds three small improvements to the Pair class:
> - toString() method
> - factory method ".create()" to avoid duplicating generic types on instance creation
> - a Comparator
> Tests are included. I won't feel offended if this is rejected or modified but just wanted
to supply  the suggestion.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message