commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt Benson (JIRA)" <>
Subject [jira] [Commented] (LANG-910) Patch to extend StringUtils
Date Mon, 21 Oct 2013 13:51:43 GMT


Matt Benson commented on LANG-910:

My primary comment is that I find the method naming uncomfortable, particularly in the case
of those returning {{String[]}}.  I would prefer this family of names instead be called {{substring\[s]Match}}_ing_.

To your last question, I feel as though I'm not understanding what you feel is "less natural"
about the way the proposed API works.  Can you elaborate on the context of your example?

> Patch to extend StringUtils
> ---------------------------
>                 Key: LANG-910
>                 URL:
>             Project: Commons Lang
>          Issue Type: Bug
>          Components: lang.*
>    Affects Versions: 3.1
>         Environment: Developed on Ubuntu 13.04 with openjdk 7u25
>            Reporter: Timur Yarosh
>              Labels: patch
>             Fix For: 3.2, Discussion
>         Attachments: LANG-910.patch, substring-matches-and-white-space-normalize.patch
> This patch extends StringUtils capabilities: added methods to find substring(s) by Pattern.
Also method org.apache.commons.lang3.StringUtils#normalizeSpace now replaces ASCII #160 char
to normal whitespace.

This message was sent by Atlassian JIRA

View raw message