commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henri Yandell (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LANG-795) Replace all "String encoding" parameters with Charset
Date Thu, 17 Oct 2013 07:31:45 GMT

    [ https://issues.apache.org/jira/browse/LANG-795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13797685#comment-13797685
] 

Henri Yandell commented on LANG-795:
------------------------------------


I've committed your patch, though I'm not sure why this would block commons-io. :)

svn ci -m "Deprecating StringUtils.toString(byte[],String) in favour of a new CharSet based
method, as reported by Aaron Digulla in LANG-795" src
Sending        src/changes/changes.xml
Sending        src/main/java/org/apache/commons/lang3/StringUtils.java
Sending        src/test/java/org/apache/commons/lang3/StringUtilsTest.java
Transmitting file data ...
Committed revision 1532995.
Crab:lang hen$ svn revert pom.xm

> Replace all "String encoding" parameters with Charset
> -----------------------------------------------------
>
>                 Key: LANG-795
>                 URL: https://issues.apache.org/jira/browse/LANG-795
>             Project: Commons Lang
>          Issue Type: New Feature
>          Components: lang.*
>    Affects Versions: 3.1
>            Reporter: Aaron Digulla
>             Fix For: 3.2
>
>         Attachments: LANG-795.patch, LANG-795.test.patch
>
>
> In several places, String constants are used to specify an encoding for data.
> Please add methods that accept {{Charset}} instead, and deprecate the existing methods.
> The goal of this change is to reduce code smell (using String constants instead of a
real value type).



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message