commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phil Steitz (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (MATH-1037) Distribution tests are mostly meaningless due to high tolerance
Date Thu, 26 Sep 2013 16:24:03 GMT

    [ https://issues.apache.org/jira/browse/MATH-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13778946#comment-13778946
] 

Phil Steitz edited comment on MATH-1037 at 9/26/13 4:23 PM:
------------------------------------------------------------

Thanks for reporting this.  This is bad and the example calls it out.  The Geometric distribution
test needs to be fixed. I am inclined to get rid of the default and make getTolerance abstract
so tests have to set it explicitly.
                
      was (Author: psteitz):
    Thanks for reporting this.  This is bad and the example calls it out.  That Geometric
distribution test needs to be fixed. I am inclined to get rid of the default and make getTolerance
abstract so tests have to set it explicitly.
                  
> Distribution tests are mostly meaningless due to high tolerance
> ---------------------------------------------------------------
>
>                 Key: MATH-1037
>                 URL: https://issues.apache.org/jira/browse/MATH-1037
>             Project: Commons Math
>          Issue Type: Bug
>    Affects Versions: 3.2
>            Reporter: Aleksei Dievskii
>            Priority: Minor
>
> The tolerance used for value comparison in {{IntegerDistributionAbstractTest}} is {{1E-4}}.
However, most values being compared are much smaller, so they are considered equal even if
they otherwise differ by orders of magnitude. For example, a typo in {{GeometricDistributionTest}}
puts 29 in the test points instead of 19, while the test probability value is correctly given
for 19. The test passes, disregarding the fact that {{2.437439e-05}} (test value for 19) and
{{1.473826e-07}} (actual value for 29) differ almost hundredfold.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message