commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <>
Subject [jira] [Commented] (IO-335) Tailer#readLines - incorrect CR handling
Date Wed, 25 Sep 2013 16:50:03 GMT


Sebb commented on IO-335:

The original bug is fixed (r1347829); the code now treats CR, LF and CRLF as line terminators.

Please open a new bug to request a change in this behaviour.
> Tailer#readLines - incorrect CR handling
> ----------------------------------------
>                 Key: IO-335
>                 URL:
>             Project: Commons IO
>          Issue Type: Bug
>            Reporter: Sebb
>            Assignee: Sebb
>             Fix For: 2.4
> The readLines method checks for CR. If found, it is not stored immediately, but a flag
is set.
> If the next char is an LF, the buffer is passed to the listener without the CR.
> As soon as the next non-LF (and non-CR) character is received, the saved CR is written
to the buffer.
> The net result is that CR before LF migrates to the start of the next non-empty line,
and repeated CRs are collapsed. This is clearly wrong.
> The original code (before IO-274) used RandomAccessFile#readLine() which returns on CR,
> It looks as though the intention was to retain this behaviour whilst not blocking.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message