commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedikt Ritter (JIRA)" <>
Subject [jira] [Resolved] (LANG-804) Redundant check for zero in HashCodeBuilder ctor
Date Fri, 27 Sep 2013 07:53:03 GMT


Benedikt Ritter resolved LANG-804.

    Resolution: Fixed
      Assignee: Benedikt Ritter

Closing this as fixed, since the initial issue has been resolved. Whether disallowing negative
parameters makes sense can be discussed in another issue.
> Redundant check for zero in HashCodeBuilder ctor
> ------------------------------------------------
>                 Key: LANG-804
>                 URL:
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.builder.*
>            Reporter: Sebb
>            Assignee: Benedikt Ritter
>            Priority: Minor
>             Fix For: 3.2
> The HashCodeBuilder(int, int) ctor checks both parameters for zero, as well as checking
for an odd number.
> Zero is never odd, so the zero check could be eliminated.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message