Return-Path: X-Original-To: apmail-commons-issues-archive@minotaur.apache.org Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4A404109EF for ; Tue, 6 Aug 2013 23:15:49 +0000 (UTC) Received: (qmail 26455 invoked by uid 500); 6 Aug 2013 23:15:48 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 26339 invoked by uid 500); 6 Aug 2013 23:15:48 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 26249 invoked by uid 99); 6 Aug 2013 23:15:48 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Aug 2013 23:15:48 +0000 Date: Tue, 6 Aug 2013 23:15:48 +0000 (UTC) From: "Dmitry Katsubo (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (LANG-909) Thread-safe wrapper for SimpleDateFormat MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LANG-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13731429#comment-13731429 ] Dmitry Katsubo commented on LANG-909: ------------------------------------- [~sebb@apache.org]: I will apply the code style changes you have mentioned. To make it easier: are there code formatting rules for Eclipse which I can download? This from [here|http://maven.apache.org/developers/conventions/code.html#Eclipse_3.2] are for Maven project and seem to be different from what Apache commons is using. Unit tests do not test different formats because from implementation it is clear that formatting is delegated to {{SimpleDateFormat}}; adding such test does not add any code or branch coverage to existing test thus to my mind it is useless. [~charles_honton@intuit.com]: Future parser looks good. Will the adapter for {{java.text.DateFormat}} be included? A lot of legacy/3rdparty code is based on that JDK API, so it would be nice to keep compatibility. > Thread-safe wrapper for SimpleDateFormat > ---------------------------------------- > > Key: LANG-909 > URL: https://issues.apache.org/jira/browse/LANG-909 > Project: Commons Lang > Issue Type: New Feature > Components: lang.time.* > Affects Versions: 3.1 > Reporter: Dmitry Katsubo > Priority: Minor > Attachments: ThreadSafeDateFormat.java, ThreadSafeDateFormatTest.java > > > {{SimpleDateFormat}} implementation in JDK is known to be [not thread-safe|http://stackoverflow.com/questions/6840803/simpledateformat-thread-safety]. The attached helper class solves the problem by holding a separate instance of {{SimpleDateFormat}} per thread. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira