Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Sat, 10 Aug 2013 01:25:51 +0000 (UTC)
From: "Gilles (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.12613979.1351559015723.38317.1376097951199@arcas>
In-Reply-To: <JIRA.12613979.1351559015723@arcas>
References: <JIRA.12613979.1351559015723@arcas>
Subject: [jira] [Updated] (MATH-887) "AbstractLeastSquares"  cleanup
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/MATH-887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gilles updated MATH-887:
------------------------

    Fix Version/s:     (was: 4.0)

All changes proposed here have been implemented while working on MATH-874 and MATH-1008.
No more changes will be applied to this class, as it will be deprecated.
                
> "AbstractLeastSquares"  cleanup
> -------------------------------
>
>                 Key: MATH-887
>                 URL: https://issues.apache.org/jira/browse/MATH-887
>             Project: Commons Math
>          Issue Type: Task
>    Affects Versions: 3.0
>            Reporter: Gilles
>            Assignee: Gilles
>            Priority: Minor
>              Labels: api-change
>         Attachments: MATH-887.diff
>
>
> Class "AbstractLeastSquares" (in package "o.a.c.m.optimization.general") has a lot of "protected" fields that are modified by its subclasses (e.g. "LevenbergMarquardt"). This decreases encapsulation which in turn makes the code more difficult to understand and modify.
> I propose to deprecate (in 3.1) and remove or make "private" (in 4.0) all fields that could be hidden or should be modified through setter methods.
> Part of the code could also be more readable (and self-documenting) by making use of higher-level constructs such as "RealMatrix" rather than using explicit loops.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira