commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gilles (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MATH-1026) Separate Optimization Problem from Algorithm
Date Wed, 28 Aug 2013 23:19:52 GMT

    [ https://issues.apache.org/jira/browse/MATH-1026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13753012#comment-13753012
] 

Gilles commented on MATH-1026:
------------------------------

bq. I didn't think that re-factoring the test cases would be an issue for the ML

Small changes are more readily accepted; big changes leave questions about whether we may
have lost something in the process.
It way well be that your proposal leads to more flexibility and/or better coverage. Those
targets should be aggreed on in advance to avoid lengthy discussions: "If it ain't broken,
why fix it?"

My view would have been
# Free Refactor code
# Minimal (necessary) refactoring of the tests

If all works, propose emprovements (probably no just rmovr the "@Test" tag from testSomething()
trest

                
> Separate Optimization Problem from Algorithm
> --------------------------------------------
>
>                 Key: MATH-1026
>                 URL: https://issues.apache.org/jira/browse/MATH-1026
>             Project: Commons Math
>          Issue Type: Improvement
>            Reporter: Evan Ward
>         Attachments: opt.tar.gz
>
>
> See discussion on the mailing list starting with: http://www.mail-archive.com/dev@commons.apache.org/msg39681.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message