commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LANG-909) Thread-safe wrapper for SimpleDateFormat
Date Tue, 06 Aug 2013 13:43:48 GMT

    [ https://issues.apache.org/jira/browse/LANG-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13730773#comment-13730773
] 

Sebb commented on LANG-909:
---------------------------

Thanks for the patch. Looks useful.

However, there are a few minor issues with the patch.
- tabs are not allowed; we use 4 spaces for indentation
- @author is deprecated in ASF code; we use other means to credit contributors.
- the files should include the standard AL header
- the class name should probably be ThreadSafeSimpleDateFormat
- the test class does not test different formats.

                
> Thread-safe wrapper for SimpleDateFormat
> ----------------------------------------
>
>                 Key: LANG-909
>                 URL: https://issues.apache.org/jira/browse/LANG-909
>             Project: Commons Lang
>          Issue Type: New Feature
>          Components: lang.time.*
>    Affects Versions: 3.1
>            Reporter: Dmitry Katsubo
>            Priority: Minor
>         Attachments: ThreadSafeDateFormat.java, ThreadSafeDateFormatTest.java
>
>
> {{SimpleDateFormat}} implementation in JDK is known to be [not thread-safe|http://stackoverflow.com/questions/6840803/simpledateformat-thread-safety].
The attached helper class solves the problem by holding a separate instance of {{SimpleDateFormat}}
per thread.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message