commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jochen Wiedmann (JIRA)" <>
Subject [jira] [Commented] (FILEUPLOAD-137) MultipartStream public API broken
Date Mon, 12 Aug 2013 13:30:48 GMT


Jochen Wiedmann commented on FILEUPLOAD-137:

Two parts:

- I fail to find any uses of "notifier", that could trigger an NPE. Namely, checks for null
are present in makeAvailable(), and readByte(). Please be more specific on that part.

-The constructor     MultipartStream(InputStream, byte[], int, ProgressNotifier) is now public.
This is an upwards compatible  change with no side effects.

> MultipartStream public API broken
> ---------------------------------
>                 Key: FILEUPLOAD-137
>                 URL:
>             Project: Commons FileUpload
>          Issue Type: Bug
>    Affects Versions: 1.2
>            Reporter: Mark Sinke
>            Assignee: Jochen Wiedmann
>             Fix For: 1.2.1
> In commons-transaction 1.2 the MultipartStream class has 2 public constructors. Both
are deprecated; however their implementation delegates to non-visible (package-private) constructors.
There are two issues here:
> 1. the deprecated, delegating constructors use a null pointer for the progress notifier,
which in turn yield a NullPointerException when you try to use them
> 2. the non-deprecated constructors are not visible.
> Hence, I cannot really upgrade from 1.0 to 1.2.
> Thanks,
> Mark.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message