Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Tue, 23 Jul 2013 02:16:49 +0000 (UTC)
From: "BELUGA BEHR (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.12656998.1373420298993.94578.1374545809069@arcas>
In-Reply-To: <JIRA.12656998.1373420298993@arcas>
References: <JIRA.12656998.1373420298993@arcas>
Subject: [jira] [Commented] (COMPRESS-234) Patch: TAR InputStream Huge Speed
 Improvements
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/COMPRESS-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13715982#comment-13715982 ] 

BELUGA BEHR commented on COMPRESS-234:
--------------------------------------

OK,  I have submitted what I believe should be the final version.  It is Archiver_Tar.3.patch.

Notes: It still fails that same unit test.  I think the unit test here is at fault.  The test runs an archive with random data appended onto the end of it.  I believe that the archive file has a lot of zero padding at the end.  The TarBuffer may have read that off as it was configured to read blocks of 10 * 512 chunks at one time.  I believe that a new file is required for this test.  Can you please verify and regenerate?


> Patch: TAR InputStream Huge Speed Improvements
> ----------------------------------------------
>
>                 Key: COMPRESS-234
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-234
>             Project: Commons Compress
>          Issue Type: Improvement
>          Components: Archivers
>            Reporter: BELUGA BEHR
>         Attachments: Archiver_Tar.2.patch, Archiver_Tar.3.patch, Archiver_Tar.patch, TarArchiveInputStream.java.patch, TarBuffer.java.patch
>
>
> I have looked over TarBuffer And TarArchiveInputStream and found some ways to improve performance orders of magnitude.
> I used a 1 GB TAR archive file (no compression).
> Times for reading all entry file names:
> Current - 630ms
> Mine - 17ms
> Times for extracting all entry files:
> Current 2446ms
> Mine - 2214ms
> As you can see, I have enhanced the "skip" methods greatly.  Actual extraction was within a margin of error and the timings bounces around a lot.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira