Return-Path: X-Original-To: apmail-commons-issues-archive@minotaur.apache.org Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 583E710202 for ; Sun, 14 Jul 2013 19:10:50 +0000 (UTC) Received: (qmail 47101 invoked by uid 500); 14 Jul 2013 19:10:50 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 47015 invoked by uid 500); 14 Jul 2013 19:10:49 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 46583 invoked by uid 99); 14 Jul 2013 19:10:49 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 14 Jul 2013 19:10:49 +0000 Date: Sun, 14 Jul 2013 19:10:49 +0000 (UTC) From: "Thomas Neidhart (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (COLLECTIONS-475) Wrong timeout handling in expiration policies of PassiveExpiringMap MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/COLLECTIONS-475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Neidhart resolved COLLECTIONS-475. ----------------------------------------- Resolution: Fixed Fixed in r1503029. > Wrong timeout handling in expiration policies of PassiveExpiringMap > ------------------------------------------------------------------- > > Key: COLLECTIONS-475 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-475 > Project: Commons Collections > Issue Type: Bug > Affects Versions: 4.0-alpha1 > Reporter: Thomas Neidhart > Priority: Minor > Fix For: 4.0 > > > The timeunit parameter in the ctor of ConstantTimeToLiveExpirationPolicy is not used. > Additionally, the validateAndConvertToMillis method is wrong, it should be changed like this: > {noformat} > private static long validateAndConvertToMillis(final long timeToLive, > final TimeUnit timeUnit) { > if (timeUnit == null) { > throw new IllegalArgumentException("Time unit must not be null"); > } > return TimeUnit.MILLISECONDS.convert(timeToLive, timeUnit); > } > {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira