commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "BELUGA BEHR (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (COMPRESS-234) Patch: TAR InputStream Huge Speed Improvements
Date Sun, 21 Jul 2013 14:00:50 GMT

    [ https://issues.apache.org/jira/browse/COMPRESS-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13714706#comment-13714706
] 

BELUGA BEHR edited comment on COMPRESS-234 at 7/21/13 2:00 PM:
---------------------------------------------------------------

[~bodewig]: Well, TarBuffer is/was the buffering stream, so by not replacing it with another
buffering stream, we are going to hurt the performance of anyone who is currently using the
library without a buffered stream.  So, I like Sebb's approach and wrapping it if need-be.
 So, by going with Sebb's approach, we need to decide if we want to set an explicit buffer
size or just go with the default size.  As long as the buffer is larger than 512 bytes (the
size of a single header), I don't see a need for us to set it.
                
      was (Author: belugabehr):
    [~bodewig] Well, TarBuffer is/was the buffering stream, so by not replacing it with another
buffering stream, we are going to hurt the performance of anyone who is currently using the
library without a buffered stream.  So, I like Sebb's approach and wrapping it if need-be.
 So, by going with Sebb's approach, we need to decide if we want to set an explicit buffer
size or just go with the default size.  As long as the buffer is larger than 512 bytes (the
size of a single header), I don't see a need for us to set it.
                  
> Patch: TAR InputStream Huge Speed Improvements
> ----------------------------------------------
>
>                 Key: COMPRESS-234
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-234
>             Project: Commons Compress
>          Issue Type: Improvement
>          Components: Archivers
>            Reporter: BELUGA BEHR
>         Attachments: Archiver_Tar.patch, TarArchiveInputStream.java.patch, TarBuffer.java.patch
>
>
> I have looked over TarBuffer And TarArchiveInputStream and found some ways to improve
performance orders of magnitude.
> I used a 1 GB TAR archive file (no compression).
> Times for reading all entry file names:
> Current - 630ms
> Mine - 17ms
> Times for extracting all entry files:
> Current 2446ms
> Mine - 2214ms
> As you can see, I have enhanced the "skip" methods greatly.  Actual extraction was within
a margin of error and the timings bounces around a lot.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message