commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COMPRESS-234) Patch: TAR InputStream Huge Speed Improvements
Date Sat, 20 Jul 2013 17:00:51 GMT

    [ https://issues.apache.org/jira/browse/COMPRESS-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13714479#comment-13714479
] 

Sebb commented on COMPRESS-234:
-------------------------------

I don't know if there is a template available, but for patches any automatic formatting is
likely to cause problems, because the existing code may not be exactly correctly styled. And
some projects have a mix of styles in different files.

Please just follow the surrounding style.

Basic rules for new code that AFAIK all Commons components use:
- no tabs; use spaces for alignment
- avoid trailing spaces
- indentation is 4 spaces (sometimes 2 in XML files)
                
> Patch: TAR InputStream Huge Speed Improvements
> ----------------------------------------------
>
>                 Key: COMPRESS-234
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-234
>             Project: Commons Compress
>          Issue Type: Improvement
>          Components: Archivers
>            Reporter: BELUGA BEHR
>         Attachments: Archiver_Tar.patch, TarArchiveInputStream.java.patch, TarBuffer.java.patch
>
>
> I have looked over TarBuffer And TarArchiveInputStream and found some ways to improve
performance orders of magnitude.
> I used a 1 GB TAR archive file (no compression).
> Times for reading all entry file names:
> Current - 630ms
> Mine - 17ms
> Times for extracting all entry files:
> Current 2446ms
> Mine - 2214ms
> As you can see, I have enhanced the "skip" methods greatly.  Actual extraction was within
a margin of error and the timings bounces around a lot.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message