commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "BELUGA BEHR (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (COMPRESS-234) Patch: TAR InputStream Huge Speed Improvements
Date Wed, 24 Jul 2013 01:07:46 GMT

    [ https://issues.apache.org/jira/browse/COMPRESS-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13717845#comment-13717845
] 

BELUGA BEHR edited comment on COMPRESS-234 at 7/24/13 1:06 AM:
---------------------------------------------------------------

Stefan,

No problem on how things have been going.  I'm not sure if you're paid staff, but regardless,
I know you have a lot on your plate.


Please let me know if you need any additional input on this ticket.  Now here comes the act
of stating the obvious: I would love to see this in and released ASAP.  Sadly, I had to abandoned
both Commons VFS and Commons Compress at work today.  I came across too many show stopping
bugs with VFS and I was getting a NULL pointer exception with TarArchiveInputStream in COMPRESS
1.5.  I had to back-fill with Java's GZIP, ZIP, and different 3rd-party TAR library.

If you're going to follow-up with changes... consider dropping isAtEOF/setAtEOF.  They're
not used anywhere in the class and some place reference the variable directly.

Follow-Up: I have included that change (and a few others) in .final.patch.


Thanks.
                
      was (Author: belugabehr):
    Stefan,

No problem on how things have been going.  I'm not sure if you're paid staff, but regardless,
I know you have a lot on your plate.


Please let me know if you need any additional input on this ticket.  Now here comes the act
of stating the obvious: I would love to see this in and released ASAP.  Sadly, I had to abandoned
both Commons VFS and Commons Compress at work today.  I came across too many show stopping
bugs with VFS and I was getting a NULL pointer exception with TarArchiveInputStream in COMPRESS
1.5.  I had to back-fill with Java's GZIP, ZIP, and different 3rd-party TAR library.

If you're going to follow-up with changes... consider dropping isAtEOF/setAtEOF.  They're
not used anywhere in the class and some place reference the variable directly.


Thanks.
                  
> Patch: TAR InputStream Huge Speed Improvements
> ----------------------------------------------
>
>                 Key: COMPRESS-234
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-234
>             Project: Commons Compress
>          Issue Type: Improvement
>          Components: Archivers
>            Reporter: BELUGA BEHR
>         Attachments: Archiver_Tar.2.patch, Archiver_Tar.3.patch, Archiver_Tar.patch,
TarArchiveInputStream.java.final.patch, TarArchiveInputStream.java.patch, TarBuffer.java.patch
>
>
> I have looked over TarBuffer And TarArchiveInputStream and found some ways to improve
performance orders of magnitude.
> I used a 1 GB TAR archive file (no compression).
> Times for reading all entry file names:
> Current - 630ms
> Mine - 17ms
> Times for extracting all entry files:
> Current 2446ms
> Mine - 2214ms
> As you can see, I have enhanced the "skip" methods greatly.  Actual extraction was within
a margin of error and the timings bounces around a lot.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message