commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefan Bodewig (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COMPRESS-233) Microbenchmarking TarBuffer#isEOFRecord
Date Mon, 08 Jul 2013 14:59:48 GMT

    [ https://issues.apache.org/jira/browse/COMPRESS-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13702044#comment-13702044
] 

Stefan Bodewig commented on COMPRESS-233:
-----------------------------------------

with your second patch (removing the null check) isEOFRecord will now return false if record
is null.  Trivial to fix but it seems we are missing a unit test if you got away with it :-)
                
> Microbenchmarking TarBuffer#isEOFRecord
> ---------------------------------------
>
>                 Key: COMPRESS-233
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-233
>             Project: Commons Compress
>          Issue Type: Improvement
>            Reporter: BELUGA BEHR
>            Priority: Minor
>         Attachments: TarBuffer.java.patch
>
>
> It's possible to speed up the regular checking of isEOFRecord by creating a buffer that
is all zeros then using the Java primitive Arrays.equals function.  My bench-marking puts
it at roughly 1/3 the time per check.  No unit tests were harmed in the production of these
modifications.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message