commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedikt Ritter (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CHAIN-86) Make CatalogFactory an interface
Date Mon, 08 Jul 2013 20:25:49 GMT

    [ https://issues.apache.org/jira/browse/CHAIN-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13702376#comment-13702376
] 

Benedikt Ritter commented on CHAIN-86:
--------------------------------------

Hi Jonas,

thanks for the patch. I've had a look and I think something has gone wrong with {{o.a.c.chain2.base.impl.CatalogFactoryBase}}:

 * several imports are missing
 * it still extends CatalogFactory (instead of implementing it)

Can you fix this? :)

TIA!
Bendikt

                
> Make CatalogFactory an interface
> --------------------------------
>
>                 Key: CHAIN-86
>                 URL: https://issues.apache.org/jira/browse/CHAIN-86
>             Project: Commons Chain
>          Issue Type: Sub-task
>          Components: API
>    Affects Versions: 2.0
>            Reporter: Benedikt Ritter
>            Assignee: Benedikt Ritter
>             Fix For: 2.0
>
>         Attachments: chain-86.patch
>
>
> Instead of of holding a reference to an implementation of itself, CatalogFactory should
be an interface that is created by ConfigParser implementations.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message