commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Neidhart (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COLLECTIONS-474) Exception in ListOrderedMap
Date Mon, 24 Jun 2013 19:06:22 GMT

    [ https://issues.apache.org/jira/browse/COLLECTIONS-474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13692264#comment-13692264
] 

Thomas Neidhart commented on COLLECTIONS-474:
---------------------------------------------

Inserting with an index >= size() usually does not work in list-based collections, so I
think the behavior is correct.
What worries me more is that the exception in put is thrown *after* the collection has been
modified, leaving it in an inconsistent state.

We should check the index first and throw the exception if it is out-of-range.
                
> Exception in ListOrderedMap
> ---------------------------
>
>                 Key: COLLECTIONS-474
>                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-474
>             Project: Commons Collections
>          Issue Type: Bug
>          Components: Map
>    Affects Versions: 4.0
>         Environment: java 1.7.0_09
>            Reporter: Ning Chen
>         Attachments: Test.java
>
>
> Dear apache developers, thanks for the great project. Recently, I encountered an IndexOutOfBoundsException
in ListOrderedMap in the latest revision (r1495998) with the crash stack trace: 
> Exception in thread "main" java.lang.IndexOutOfBoundsException: Index: 2, Size: 1
> 	at java.util.ArrayList.add(ArrayList.java:367)
> 	at org.apache.commons.collections4.map.ListOrderedMap.put(ListOrderedMap.java:448)
> 	at org.apache.commons.collections4.map.ListOrderedMap.putAll(ListOrderedMap.java:246)
> 	at Test.main(Test.java:15)
> I've also attached a test case that can reproduce this crash.
> I think this test case actually reveals the bug reported in COLLECTIONS-411 (https://issues.apache.org/jira/browse/COLLECTIONS-411).
However, it seems that the original patch for COLLECTIONS-411 missed a corner case.
> Could you please check if this is indeed a bug? Thanks!

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message