commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrzej Winnicki (JIRA)" <j...@apache.org>
Subject [jira] [Created] (LANG-902) RandomStringUtils.random (count, letters=true, number=true) may not use numerics
Date Fri, 21 Jun 2013 12:26:19 GMT
Andrzej Winnicki created LANG-902:
-------------------------------------

             Summary: RandomStringUtils.random (count, letters=true, number=true) may not
use numerics
                 Key: LANG-902
                 URL: https://issues.apache.org/jira/browse/LANG-902
             Project: Commons Lang
          Issue Type: Bug
          Components: lang.*
    Affects Versions: 3.1
            Reporter: Andrzej Winnicki
            Priority: Minor


Either there is a bug in an implementation or misunderstanding in docs.

RandomStringUtils.random (count, letters, numbers) is documented so that:

letters  if true, generated string *will* include alphabetic characters
numbers  if true, generated string *will* include numeric characters

But apparently the current implementation supports only that generated string *may* include
either only letters, only numbers or both.

This is current implementation:

 if (letters && Character.isLetter(ch)
                    || numbers && Character.isDigit(ch)
                    || !letters && !numbers)

So there may be situation when generated string is not containing numbers at all which is
in contrary with what the docs say. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message