commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonas Sprenger (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CHAIN-98) Refactor command interface and base Implementations to enumeration to represent states
Date Sat, 22 Jun 2013 22:56:20 GMT

    [ https://issues.apache.org/jira/browse/CHAIN-98?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13691275#comment-13691275
] 

Jonas Sprenger commented on CHAIN-98:
-------------------------------------

I added a patch for refactoring to the Processing enum. 

Some comments on that patch: 
1. ChainBase executes commands until COMPLETE OR ABORTED is returned by a command
2. Test Classes switched to Prcoessing return values
3. All relevant asserts switched to 'assertEquals' instead of assertTrue/False 
4. All comments regarding 'true' or 'false' regarding Processing values have been adjusted
5. I added to 'FIXME' comments to mark locations where a returning null instead of a processing
value could be an issue, i.e. DispatchCommand and DispatchLookupCommand.

                
> Refactor command interface and base Implementations to enumeration to represent states
> --------------------------------------------------------------------------------------
>
>                 Key: CHAIN-98
>                 URL: https://issues.apache.org/jira/browse/CHAIN-98
>             Project: Commons Chain
>          Issue Type: Task
>    Affects Versions: 2.0
>            Reporter: Jonas Sprenger
>             Fix For: 2.0
>
>
> Base implementations should return the constants CONTINUE_PROCESSING or PROCESSING_COMPLETE
instead of returning true or false

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message