commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Neidhart (JIRA)" <>
Subject [jira] [Commented] (COLLECTIONS-473) AbstractCollectionDecorator.decorated() should not be used internally
Date Tue, 18 Jun 2013 20:12:21 GMT


Thomas Neidhart commented on COLLECTIONS-473:

I have already done the changes in r1494280:

 * made the collection field private
 * added a protected setter with javadoc stating that it should only be used for de-serialization
 * updated all other decorators to the the getters/setters instead of the plain field.

Is it ok like that?
> AbstractCollectionDecorator.decorated() should not be used internally
> ---------------------------------------------------------------------
>                 Key: COLLECTIONS-473
>                 URL:
>             Project: Commons Collections
>          Issue Type: Bug
>            Reporter: Sebb
> AbstractCollectionDecorator.decorated() is used internally to access the collection.
> However, the method is not final, so subclasses could override it.
> Yet the field is also exposed (protected).
> This is inconsistent.
> Is there any use-case for overriding the collection to use a different one?
> If so, having direct access as well is likely to cause problems.
> I think it would be better to use the field directly internally.
> The class Javadoc says the calls are forwarded to the underlying collection, but that
is not strictly true if decorated() is overridden.
> If it is intended to allow this to be overridden, then the field needs to be protected
against arbitrary read/write access.
> The field should probably be made private with a setter for use by deserialization only.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message