commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Evgeniy Philippov (JIRA)" <j...@apache.org>
Subject [jira] [Created] (FILEUPLOAD-234) Bug in docs: tmp file delete conditions in "Resource Cleanup" section of "using.html"
Date Thu, 13 Jun 2013 11:39:20 GMT
Evgeniy Philippov created FILEUPLOAD-234:
--------------------------------------------

             Summary: Bug in docs: tmp file delete conditions in "Resource Cleanup" section
of "using.html"
                 Key: FILEUPLOAD-234
                 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-234
             Project: Commons FileUpload
          Issue Type: Bug
            Reporter: Evgeniy Philippov
            Priority: Critical


The guide at http://commons.apache.org/proper/commons-fileupload/using.html incorrectly writes:
"Such temporary files are deleted automatically, if they are no longer used (more precisely,
if the corresponding instance of java.io.File is garbage collected.".

(Affects maven version: /home/user1/.m2/repository/commons-fileupload/commons-fileupload/1.2.2/commons-fileupload-1.2.2.jar)

However, the code for org.apache.commons.io.FileCleaningTracker.Tracker.Tracker(...) passes
org.apache.commons.fileupload.disk.DiskFileItemFactory.this specified by org.apache.commons.fileupload.disk.DiskFileItemFactory.createItem(String,
String, boolean, String) in tracker.track(result.getTempFile(), this), and not java.io.File.
I.e. the "using.html" guide must be corrected.

The correct (fixed) phrasing is: 

"Such temporary files are deleted automatically, if they are no longer used (more precisely,
if the corresponding instance of org.apache.commons.fileupload.disk.DiskFileItemFactory is
garbage collected.".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message