commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phil Steitz (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (MATH-987) SimpleRegression needs to be map/reducable
Date Mon, 03 Jun 2013 05:46:20 GMT

     [ https://issues.apache.org/jira/browse/MATH-987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Phil Steitz resolved MATH-987.
------------------------------

       Resolution: Fixed
    Fix Version/s: 4.0

Patch applied in r1488849 with the following changes:

* Changed the name of the new method from addData to append.  I understand the rationale for
overloading addData here, but the actual parameter is another instance, not just data.  I
think we should standardize on append for the name of this operation.  Will happily change
back if others disagree.
* Moved the "equals" method to the test class and changed it to test reported stats.  There
is an argument for implementing equals in the class itself, but the problem is the need for
the tolerance parameter.  We just need it for test for now, so I thought it best to implement
an equals with a tolerance parameter in the test class.

Many thanks for the patch.
                
> SimpleRegression needs to be map/reducable
> ------------------------------------------
>
>                 Key: MATH-987
>                 URL: https://issues.apache.org/jira/browse/MATH-987
>             Project: Commons Math
>          Issue Type: New Feature
>            Reporter: Ajo Fod
>             Fix For: 4.0
>
>         Attachments: patch
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> For map/reduce to work with SimpleRegression, there should be a way to add together stats
from multiple SimpleRegression objects.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message