commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEANUTILS-441) Replace UnmodifiableSet.decorate with Collections.unModifiableSet
Date Fri, 21 Jun 2013 11:31:20 GMT

    [ https://issues.apache.org/jira/browse/BEANUTILS-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13690199#comment-13690199
] 

Sebb commented on BEANUTILS-441:
--------------------------------

Thanks, but the patch changes some lines that are not related.
Also the patch changes the indentation, so the difference is much larger than it need be.

It also looks like the Javadoc for public Set keySet() has been duplicated with minor changes.

It's much easier for patches to be reviewed (and maybe accepted) if they only change the minimum
needed.
                
> Replace UnmodifiableSet.decorate with Collections.unModifiableSet
> -----------------------------------------------------------------
>
>                 Key: BEANUTILS-441
>                 URL: https://issues.apache.org/jira/browse/BEANUTILS-441
>             Project: Commons BeanUtils
>          Issue Type: Bug
>            Reporter: Sebb
>         Attachments: BEANUTILS-441.patch
>
>
> Two methods in BeanUtils call UnmodifiableSet.decorate() from Commons Collections.
> These calls could be replaced with the standard Java method Collections.unmodifiableSet()

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message