commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Neidhart (JIRA)" <>
Subject [jira] [Commented] (COLLECTIONS-459) ArrayIterator & ObjectArrayIterator - do they need setters?`
Date Tue, 18 Jun 2013 08:33:20 GMT


Thomas Neidhart commented on COLLECTIONS-459:

I started doing this, but after I had the code the retrieve the array to alter or access an
element I was unhappy with the result.
The fields are already final, thus unmodifiable by sub-classes.

Also keep in mind that iterators in general are not supposed to be thread-safe, so I do not
see the point in trying to achieve something that is not necessary.
> ArrayIterator & ObjectArrayIterator - do they need setters?`
> ------------------------------------------------------------
>                 Key: COLLECTIONS-459
>                 URL:
>             Project: Commons Collections
>          Issue Type: Bug
>            Reporter: Sebb
>             Fix For: 4.0
> ArrayIterator & ObjectArrayIterator both have methods to set the array separately
from the ctor.
> However the method does not allow the same flexibility as the ctor, as it does not allow
the start or end indexes to be set.
> Is there really a use-case for these setters? If not, all the fields apart from index
could be made final, which would make thread safety (and testing) easier.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message