commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Neidhart (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COLLECTIONS-455) AbstractDualBidiMap<K, V> has several mutable protected fields
Date Mon, 17 Jun 2013 19:37:22 GMT

    [ https://issues.apache.org/jira/browse/COLLECTIONS-455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13685892#comment-13685892
] 

Thomas Neidhart commented on COLLECTIONS-455:
---------------------------------------------

For all the abstract decorator classes I am in favor to keep the things as they are for the
following reasons:

 * the use and purpose of such abstract classes is clear
 * refactoring the serialization code is just additional work and does not bring any benefits
                
> AbstractDualBidiMap<K, V> has several mutable protected fields
> --------------------------------------------------------------
>
>                 Key: COLLECTIONS-455
>                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-455
>             Project: Commons Collections
>          Issue Type: Bug
>            Reporter: Sebb
>             Fix For: 4.0
>
>
> Any non-private mutable fields make it much harder to ensure thread-safety as well as
making it very difficult to test thoroughly.
> The fields should be made private.
> If protected write access really is needed, setter methods should be used.
> These methods can take any necessary precautions to ensure thread-safety.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message